[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/3] kernel-2.eclass: add masked-by-default IUSE=experimental-loong
From:       WANG Xuerui <xen0n () gentoo ! org>
Date:       2022-04-23 7:31:29
Message-ID: ffdd2053-31f1-df02-d468-6d3c04d97db1 () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]

[Attachment #4 (multipart/mixed)]

[Attachment #6 (text/plain)]

On 4/23/22 14:25, Michał Górny wrote:

> On Sat, 2022-04-23 at 13:15 +0800, WANG Xuerui wrote:
>> Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
>> ---
>>   eclass/kernel-2.eclass              | 2 ++
>>   profiles/arch/base/package.use.mask | 1 +
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
>> index 02c70422ee07..9d9d3fbb6f96 100644
>> --- a/eclass/kernel-2.eclass
>> +++ b/eclass/kernel-2.eclass
>> @@ -729,6 +729,8 @@ elif [[ ${ETYPE} == headers ]]; then
>>   	DESCRIPTION="Linux system headers"
>>   	IUSE="headers-only"
>>   
>> +	ver_test "${PV}" -ge 5.17 && IUSE+=" experimental-loong"
> Why add this via the eclass if the whole logic is in the ebuild anyway?
So I suppose it's okay to IUSE+=" experimental-loong" after inheriting 
kernel-2 then? I'm not sure I've seen this usage before, as I thought 
the eclass should fully own the IUSE variable, but the approach works 
and I'll prepare v2 shortly.

-- 
WANG Xuerui
xen0n@gentoo.org
Gentoo Linux developer
PGP: 7C52 19E3 26A0 7311 3EA3 8806 C01F 7214 BC93 1414


["OpenPGP_0xC01F7214BC931414.asc" (application/pgp-keys)]
["OpenPGP_signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]