[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Document variables, minor style clean-up
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2022-02-18 18:57:36
Message-ID: CAJ0EP41u-88Na9oq57X63j6qG1S2A0QxZB=Wgi4py5MWpjr5Sw () mail ! gmail ! com
[Download RAW message or body]

On Fri, Feb 18, 2022 at 1:01 PM Mike Pagano <mpagano@gentoo.org> wrote:
>
> Document variables in the eclass, reorder alphabetically.
> Make spacing consistent in comment lines.

For review purposes, I wish you had split this into two commits: one
to reorder/reformat the existing vars, and one to add the new ones.

Anyway, I think the kernel version vars (KV_*) should be tagged with
@OUTPUT_VARIABLE.

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic