[prev in list] [next in list] [prev in thread] [next in thread]
List: gentoo-dev
Subject: Re: [gentoo-dev] [PATCH 5/6] distutils-r1.eclass: Add DISTUTILS_DEPS output var for PEP 517 mode
From: Sam James <sam () gentoo ! org>
Date: 2022-01-31 23:06:54
Message-ID: 3BF00E60-2696-4801-BDDF-F1D839D497F8 () gentoo ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 31 Jan 2022, at 22:59, Michał Górny <mgorny@gentoo.org> wrote:
>
> The PEP 517 build-time deps have gotten more complex, and largely depend
> on the internal eclass logic used to build and install wheels.
> Introduce a DISTUTILS_DEPS output variable that contains the correct
> BDEPEND string for use in DISTUTILS_OPTIONAL=1 ebuilds.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
All LGTM (checked when on GH), but add bug ref to this commit:
https://bugs.gentoo.org/832337 <https://bugs.gentoo.org/832337>.
Best,
sam
[Attachment #5 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote \
type="cite" class=""><div class="">On 31 Jan 2022, at 22:59, Michał Górny <<a \
href="mailto:mgorny@gentoo.org" class="">mgorny@gentoo.org</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div class="">The PEP 517 build-time \
deps have gotten more complex, and largely depend<br class="">on the internal eclass \
logic used to build and install wheels.<br class="">Introduce a DISTUTILS_DEPS output \
variable that contains the correct<br class="">BDEPEND string for use in \
DISTUTILS_OPTIONAL=1 ebuilds.<br class=""><br class="">Signed-off-by: Michał Górny \
<<a href="mailto:mgorny@gentoo.org" class="">mgorny@gentoo.org</a>><br \
class="">---</div></div></blockquote><br class=""></div><div>All LGTM (checked when \
on GH), but add bug ref to this commit:</div><div><a \
href="https://bugs.gentoo.org/832337" \
class="">https://bugs.gentoo.org/832337</a>.</div><div><br \
class=""></div><div>Best,</div><div>sam</div></body></html>
["signature.asc" (signature.asc)]
-----BEGIN PGP SIGNATURE-----
iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmH4a45fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw
RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g
SDvBgwgAnFgO48Ie8KsF4V3iJPu51WzQIU3L3PihJ0OMTVXQ6E36nh29zfpqXnBr
utW911lE57CzrAz2iTVVNULKY0pk2+V/agiu/xH7KHcaw2eeYF5kRi1wgOMbosKv
WYVppgYk5yJLXyD+Ja26kNdYr0pSB42/4SCWgyGhhBAHHZCLyE1iDePdw74UqGcO
z17hpabQQrys3nNWKdjvCi/A4hmMiuEuHm5pG4iMwon00NoiW+J4GqZUf5Of0TWu
W0iHmWkj9TEv2a+MNYdxwA2FTaQDXmiO2bUOGQwao5tkoGWkYxYf9CFVHNcmaGh4
sHKHc/DgnMLnWWAg7OxnA0MyV8KTsA==
=eDlm
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic