[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH v2 1/2] kernel-2.eclass: Replace bit-shift arithmetic by ver_test
From:       Ulrich =?utf-8?Q?M=C3=BCller?= <ulm () gentoo ! org>
Date:       2021-08-28 5:52:38
Message-ID: uo89iw1y1 () gentoo ! org
[Download RAW message or body]


> +	ver_test \
> +		"${KV_MAJOR:-0}.${KV_MINOR:-0}.${KV_PATCH:-0}" \
> +		"${operator}" \
> +		"${1:-${KV_MAJOR:-0}}.${2:-${KV_MINOR:-0}}.${3:-${KV_PATCH:-0}}"

I've added fallbacks to 0, because it turns out that these components
can be empty.

There may also be a problem in detect_version().
For gentoo-sources-5.10.52 I get: 

   KV_MAJOR=5
   KV_MINOR=10
   KV_PATCH=52

but for git-sources-5.14_rc7:

   KV_MAJOR=5
   KV_MINOR=   # empty
   KV_PATCH=14

According to a comment in detect_version() the intended behaviour is
"if KV_MAJOR >= 3, then we have no more KV_MINOR" but looks like that
isn't always happening.

Ulrich

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]