[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] [PATCH] distutils-r1.eclass: Switch dift default to --via-root
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2021-01-23 9:37:07
Message-ID: 20210123093707.130743-1-mgorny () gentoo ! org
[Download RAW message or body]

[I would like to push this along with the changeset 'mostly removing'
 py2.7 support]

Switch the default distutils_install_for_testing behavior to --via-root
(from legacy --via-home).  The old versions of setuptools where
--via-home worked are gone, and testing has so far proven that
--via-root in the worst case leaves package as broken as before.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 eclass/distutils-r1.eclass | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 5ffc91be479c..773806e32d93 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: distutils-r1.eclass
@@ -547,11 +547,11 @@ esetup.py() {
 # For most of the packages, tests built in BUILD_DIR are good enough.
 #
 # The function supports two install modes.  The current default is
-# the legacy --via-home mode.  However, it has problems with newer
-# versions of setuptools (50.3.0+).  The --via-root mode generally
-# works for these packages, and it will probably become the default
-# in the future, once we test all affected packages.  Please note
-# that proper testing sometimes requires unmerging the package first.
+# --via-root mode.  Previously, the function defaulted to --via-home
+# mode but it has been broken by new versions of setuptools (50.3.0+).
+# If you find that --via-root does not work but --via-home does, please
+# file a bug to let us know.  Please note that proper testing sometimes
+# requires unmerging the package first.
 distutils_install_for_testing() {
 	debug-print-function ${FUNCNAME} "${@}"
 
@@ -572,7 +572,7 @@ distutils_install_for_testing() {
 	PATH=${bindir}:${PATH}
 	PYTHONPATH=${libdir}:${PYTHONPATH}
 
-	local install_method=home
+	local install_method=root
 	case ${1} in
 		--via-home)
 			install_method=home
-- 
2.30.0


[prev in list] [next in list] [prev in thread] [next in thread]