[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] multilib.eclass: Include /$(get_libdir) in PKG_CONFIG_SYSTEM_LIBRARY_PATH.
From:       Sergei Trofimovich <slyfox () gentoo ! org>
Date:       2020-11-24 7:50:04
Message-ID: 20201124075004.4e5338c7 () sf
[Download RAW message or body]

On Mon, 23 Nov 2020 21:55:35 -0500
Mike Gilbert <floppym@gentoo.org> wrote:

> From: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
> 
> Set also PKG_CONFIG_SYSTEM_INCLUDE_PATH for consistency.
> 
> Bug: https://bugs.gentoo.org/756238
> Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
> ---
>  eclass/multilib.eclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/eclass/multilib.eclass b/eclass/multilib.eclass
> index 9c7042fcd29..33ca9726131 100644
> --- a/eclass/multilib.eclass
> +++ b/eclass/multilib.eclass
> @@ -498,6 +498,7 @@ multilib_toolchain_setup() {
>  		STRIP
>  		PKG_CONFIG_LIBDIR
>  		PKG_CONFIG_PATH
> +		PKG_CONFIG_SYSTEM_INCLUDE_PATH
>  		PKG_CONFIG_SYSTEM_LIBRARY_PATH
>  	)
>  
> @@ -547,7 +548,8 @@ multilib_toolchain_setup() {
>  		export CHOST=$(get_abi_CHOST $1)
>  		export PKG_CONFIG_LIBDIR=${EPREFIX}/usr/$(get_libdir)/pkgconfig
>  		export PKG_CONFIG_PATH=${EPREFIX}/usr/share/pkgconfig
> -		export PKG_CONFIG_SYSTEM_LIBRARY_PATH=${EPREFIX}/usr/$(get_libdir)
> +		export PKG_CONFIG_SYSTEM_INCLUDE_PATH=${EPREFIX}/usr/include
> +		export PKG_CONFIG_SYSTEM_LIBRARY_PATH=${EPREFIX}/$(get_libdir):${EPREFIX}/usr/$(get_libdir)
>  	fi
>  }

The patch looks good. Feel free to push.

-- 

  Sergei

[prev in list] [next in list] [prev in thread] [next in thread]