[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] acct-*.eclass: Create sysusers.d files
From:       Marek Szuba <marecki () gentoo ! org>
Date:       2020-08-31 13:03:46
Message-ID: b48b40d3-fbae-d614-bb9e-c902f9051177 () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 2020-08-29 21:53, Michał Górny wrote:

> +	newins - ${CATEGORY}-${ACCT_USER_NAME}.conf < <(
> +		printf "u\t%q\t%q\t%q\t%q\t%q\n" \
> +			"${ACCT_USER_NAME}" \
> +			"${ACCT_USER_ID/#-*/-}:${ACCT_USER_GROUPS[0]}" \
> +			"${DESCRIPTION//[:,=]/;}" \

Maybe it's a fault in how I have tested this (i.e. in an interactive
bash session, by setting all the variables and copy-pasting the relevant
printf lines by hand) but for me this results in an unquoted GECOS
string with spaces escaped with backslashes, whereas sysusers.d(5)
explicitly states this should be enclosed in quotation marks. Could you
double-check, please?

Otherwise LGTM.

-- 
MS


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]