[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304
From:       Sergei Trofimovich <slyfox () gentoo ! org>
Date:       2020-05-25 20:48:51
Message-ID: 20200525214851.2510f2e5 () sf
[Download RAW message or body]

On Mon, 25 May 2020 11:30:29 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> On Mon, May 25, 2020 at 9:06 AM Sergei Trofimovich <slyfox@gentoo.org> wrote:
> >
> > Bug: https://bugs.gentoo.org/725304
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>  
> 
> Both patches look good to me.
> 
> However, I think you should remove the bug number from the summary
> line; it makes the summary too long and the Bug tag later in the
> commit message is sufficient.

Sounds good! Dropped bug number and pushed as:
  https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ccdea417c4a259a03a745e3a977ac56827be5ae4
  https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bd13f6d55a51f2a1f4da69a41df7973fa7503cc

-- 

  Sergei

[prev in list] [next in list] [prev in thread] [next in thread]