[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions
From:       Michał_Górny <mgorny () gentoo ! org>
Date:       2019-04-30 17:13:19
Message-ID: 4c7b3db94427ac862f2878514972dfa3ed3fb212.camel () gentoo ! org
[Download RAW message or body]

On Tue, 2019-04-30 at 18:57 +0200, Haelwenn (lanodan) Monnier wrote:
> [2019-04-30 07:38:56+0200] Michał Górny:
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> >  eclass/llvm.eclass | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/eclass/llvm.eclass b/eclass/llvm.eclass
> > index 618a924bbb87..e4052a6400c0 100644
> > --- a/eclass/llvm.eclass
> > +++ b/eclass/llvm.eclass
> > @@ -17,18 +17,19 @@
> >  # a proper dependency string yourself to guarantee that appropriate
> >  # version of LLVM is installed.
> >  #
> > -# Example use for a package supporting LLVM 3.8 to 5:
> > +# Example use for a package supporting LLVM 5 to 7:
> >  # @CODE
> >  # inherit cmake-utils llvm
> >  #
> >  # RDEPEND="
> > -#	<sys-devel/llvm-6:=
> > +#	<sys-devel/llvm-8:=
> >  #	|| (
> > +#		sys-devel/llvm:7
> > +#		sys-devel/llvm:6
> >  #		sys-devel/llvm:5
> > -#		sys-devel/llvm:4
> > -#		>=sys-devel/llvm-3.8:0
> >  #	)
> >  # "
> > +# DEPEND=${RDEPEND}
> >  #
> >  # LLVM_MAX_SLOT=5
> 
> Shouldn't LLVM_MAX_SLOT be set to 7 as well?
> 

Indeed.  Thanks for catching that.

-- 
Best regards,
Michał Górny



[prev in list] [next in list] [prev in thread] [next in thread]