[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver
From:       "Marty E. Plummer" <hanetzer () startmail ! com>
Date:       2019-02-23 2:51:12
Message-ID: 20190223025111.6iokyq2z3gjhhroy () proprietary-killer
[Download RAW message or body]

On Thu, Feb 21, 2019 at 03:30:32PM +0100, Andreas Sturmlechner wrote:
> On Montag, 17. Dezember 2018 09:09:13 CET Marty E. Plummer wrote:
> > @@ -15,7 +15,7 @@
> >  # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for
> > packages # that have optional Java support. In addition you can inherit
> > java-ant-2 for # Ant-based packages.
> > -inherit eutils versionator multilib
> > +inherit eutils multilib
> 
> I would recommend to keep inheriting all those eclasses (including 
> versionator) for EAPI 0-6, in order not to break revdeps with implicit use. 
> Who knows in what shape they are, and no one is going to fix them for a long 
> time. But we don't want to inherit any of them with EAPI-7, hence merge it 
> with below hunk.
> 
Yeah, I came to the same conclusion when I suggested a move from
versionator to eapi7-ver for gnome.org.eclass and it had implicit deps
on versionator in its consumers.
> > @@ -25,6 +25,9 @@ export WANT_JAVA_CONFIG="2"
> >  # Prefix variables are only available for EAPI>=3
> >  has "${EAPI:-0}" 0 1 2 && ED="${D}" EPREFIX= EROOT="${ROOT}"
> > 
> > +# EAPI 7 has version functions built-in. Use eapi7-ver for all earlier 
> > eclasses.
> > +[[ ${EAPI} == [0123456] ]] && inherit eapi7-ver
> > +
> >  # @VARIABLE: JAVA_PKG_E_DEPEND
> >  # @INTERNAL
> >  # @DESCRIPTION:
> 
> 
> Regards,
> Andreas
> 
> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]