[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
From:       "Marty E. Plummer" <hanetzer () startmail ! com>
Date:       2018-06-27 7:07:59
Message-ID: 20180627070759.yuxcex6lthstvt4v () proprietary-killer
[Download RAW message or body]

On Wed, Jun 27, 2018 at 08:37:04AM +0200, Michał Górny wrote:
> W dniu śro, 27.06.2018 o godzinie 06∶58 +0200, użytkownik Ulrich Mueller
> napisał:
> > > > > > > On Tue, 26 Jun 2018, Marty E Plummer wrote:
> > > Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
> > > as a number of executables which will need to be executed on the build
> > > host are included in them.
> > > Package-Manager: Portage-2.3.40, Repoman-2.3.9
> > > ---
> > >  eclass/xdg.eclass | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
> > > index 2a4e1f81abf..fc4bee30ca5 100644
> > > --- a/eclass/xdg.eclass
> > > +++ b/eclass/xdg.eclass
> > > @@ -26,6 +26,7 @@ DEPEND="
> > >  	dev-util/desktop-file-utils
> > >  	x11-misc/shared-mime-info
> > >  "
> > > +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
> > 
> > Are these also needed in DEPEND? If not, you should set DEPEND="" in
> > EAPI 7.
> > 
> 
> Technically, they don't belong in either because they're run
> in pkg_post* phases only.
> 
Huh. well, should there not be some way to specify that they are needed
for the pkg_post* phases or should I just drop them entirely?
> -- 
> Best regards,
> Michał Górny



[prev in list] [next in list] [prev in thread] [next in thread]