[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] [PATCH 1/1] profiles: unset USE=session in default/linux/make.defaults.
From:       Michael Orlitzky <mjo () gentoo ! org>
Date:       2017-12-27 0:35:39
Message-ID: 20171227003539.31869-1-mjo () gentoo ! org
[Download RAW message or body]

The "session" USE flag has been enabled by default for all linux
profiles in default/linux/make.defaults since 2010. According to the
comment in that file, the flag was added for dev-lang/php where
session support is near-critical. But, now that we have an IUSE
default, the global setting is redundant.

This commit drops USE=session from the default/linux profile's
make.defaults, and also drops the (now unnecessary) override of that
flag in the features/hardened profile's make.defaults.

A few other packages with "session" in IUSE will be affected by this
change; however, the meaning of "session" varies wildly between the
packages that use it. Since the meaning of "session" is dependent on
the package in question, within the package itself (that is, with IUSE
defaults) is a better place to enable this flag by default.

Closes: https://bugs.gentoo.org/635742
---
 profiles/default/linux/make.defaults     | 2 +-
 profiles/features/hardened/make.defaults | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
index 899637eb7f4..4d580b1ba06 100644
--- a/profiles/default/linux/make.defaults
+++ b/profiles/default/linux/make.defaults
@@ -23,7 +23,7 @@ USE="${USE} seccomp"
 # These USE flags were originally inserted here because of PHP
 # and were later removed by me. Reinserting the USE flags again because they are
 # global USE flags that may be expected to be set by other packages.
-USE="${USE} cli pcre session"
+USE="${USE} cli pcre"
 
 # 2006/03/07 - Donnie Berkholz <dberkholz@gentoo.org>
 # Modular X: Support direct rendering by default
diff --git a/profiles/features/hardened/make.defaults b/profiles/features/hardened/make.defaults
index f6389585334..1502b08728f 100644
--- a/profiles/features/hardened/make.defaults
+++ b/profiles/features/hardened/make.defaults
@@ -22,6 +22,6 @@ USE="${USE} -ptpax"
 # We unset them so we get a clean use flag profile.
 USE="${USE} -berkdb -gdbm -tcpd"
 USE="${USE} -fortran"
-USE="${USE} -cli -session"
+USE="${USE} -cli"
 USE="${USE} -dri"
 USE="${USE} -modules"
-- 
2.13.6


[prev in list] [next in list] [prev in thread] [next in thread]