[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH v2] java-ant-2.eclass: Replace unnecessary evals with arrays
From:       James Le Cuirot <chewi () gentoo ! org>
Date:       2017-02-25 14:26:54
Message-ID: 20170225142654.2485fbb8 () symphony ! aura-online ! co ! uk
[Download RAW message or body]


On Wed, 22 Feb 2017 22:54:22 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Replace the horrifying use of evals along with quoting to pass multiple
> filenames whitespace-safe with much simpler bash arrays. While at it,
> also simplify the find-read loop.

I've given this a rough test. Some of the code paths are rarely used
and I suspect some are never used now but it looks good anyway. Please
go ahead.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]