[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] linux-mod.eclass: Check for !TRIM_UNUSED_KSYMS
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2016-11-30 11:48:03
Message-ID: CAJ0EP40hkRadU1JcgDt7Zs+tdPgLkpdZX+Wy3cab2w5w6U_uQw () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 30, 2016 at 6:16 AM, Jeroen Roovers <jer@gentoo.org> wrote:
> On Tue, 29 Nov 2016 10:39:04 -0500
> Mike Gilbert <floppym@gentoo.org> wrote:
>
>> On Tue, Nov 29, 2016 at 9:14 AM, Jeroen Roovers <jer@gentoo.org>
>> wrote:
>> > --- a/eclass/linux-mod.eclass
>> > +++ b/eclass/linux-mod.eclass
>> > @@ -566,6 +566,9 @@ linux-mod_pkg_setup() {
>> >                 return
>> >         fi
>> >
>> > +       # External modules use kernel symbols (bug #591832)
>> > +       export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
>> > +
>> >         linux-info_pkg_setup;
>> >         require_configured_kernel
>> >         check_kernel_built;
>> >
>>
>> There is no need to export CONFIG_CHECK to the environment here.
>
> Interesting. The same is done in linux-mod_pkg_setup_binary(), so which?

As far as I know, it's a bash variable used by functions defined in
linux-info.eclass. It does not need to be passed to any child
processes, and so it does not need to be defined in the environment.

The export in linux-mod_pkg_setup_binary is unnecessary as well.

[prev in list] [next in list] [prev in thread] [next in thread]