[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support EAPI 6 when applying user patches.
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2016-11-29 11:49:49
Message-ID: 20161129124949.175f147a.mgorny () gentoo ! org
[Download RAW message or body]


On Tue, 29 Nov 2016 09:46:18 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> On Mon, 28 Nov 2016 06:42:44 -0500
> Mike Pagano <mpagano@gentoo.org> wrote:
> 
> > On 11/27/2016 09:06 PM, Mike Gilbert wrote:  
> > > On Sun, Nov 27, 2016 at 7:23 PM, Mike Pagano <mpagano@gentoo.org> wrote:    
> > >> If kernel-2_src_unpack() is called in EAPI6, epatch_user() function
> > >> inherited from eutils.eclass is undefined.
> > >> See bug #579188    
> > > 
> > > kernel-2.eclass currently calls die in global scope for EAPI 6, so
> > > this change has no real effect.
> > > 
> > > I would suggest modernizing the eclass before allowing it to be used
> > > with EAPI 6. For example, patches should be applied in src_prepare,
> > > not src_unpack.
> > >     
> > 
> > Is this change not a step in the right direction? Or should it just be
> > one big bang?
> > All or nothing?  
> 
> While I don't mean incremental changes, I'd really prefer if they made

s/mean/mind/.


-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]