[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: export compilers to environment instead of setting 
From:       Alexis Ballier <aballier () gentoo ! org>
Date:       2016-11-04 12:37:42
Message-ID: 20161104133742.157aab8f () gentoo ! org
[Download RAW message or body]

On Fri, 4 Nov 2016 12:33:37 +0000
James Le Cuirot <chewi@gentoo.org> wrote:

> On Fri, 4 Nov 2016 13:20:16 +0100
> Alexis Ballier <aballier@gentoo.org> wrote:
> 
> > On Thu,  3 Nov 2016 00:52:17 +0100
> > Maciej Mrozowski <reavertm@gmail.com> wrote:
> >   
> > > From: Maciej Mrozowski <reavertm@gentoo.org>
> > > 
> > > ---
> > >  eclass/cmake-utils.eclass | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
> > > index 88d2163..23cc094 100644
> > > --- a/eclass/cmake-utils.eclass
> > > +++ b/eclass/cmake-utils.eclass
> > > @@ -525,13 +525,13 @@ enable_cmake-utils_src_configure() {
> > >  
> > >  	local toolchain_file=${BUILD_DIR}/gentoo_toolchain.cmake
> > >  	cat > ${toolchain_file} <<- _EOF_ || die
> > > -		SET (CMAKE_C_COMPILER $(tc-getCC))
> > > -		SET (CMAKE_CXX_COMPILER $(tc-getCXX))
> > > -		SET (CMAKE_Fortran_COMPILER $(tc-getFC))
> > >  		SET (CMAKE_AR $(type -P $(tc-getAR)) CACHE
> > > FILEPATH    
> > 
> > 
> > Have you tested cross compiling ?
> > IIRC toolchain file is used *before* getting those vars from env and
> > is used to determine system & compiler type. Without this you get
> > bugs like #503216  
> 
> I was dubious (since I filed that bug) but I briefly tested by
> cross-compiling media-libs/openal and it worked. I didn't think to try
> older CMake versions though. The behaviour might have changed.
> 

could you please send me (in private) build logs with & without the
changes please ?

(dont have easy access to a x compile setup atm)

[prev in list] [next in list] [prev in thread] [next in thread]