[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2016-05-29 17:21:06
Message-ID: 20160529192106.55997201.mgorny () gentoo ! org
[Download RAW message or body]


On Sun, 29 May 2016 18:49:22 +0200
Joerg Bornkessel <hd_brummy@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Am 26.05.2016 um 11:16 schrieb Michał Górny:
> > Since you already committed it with all the todos inside, just the
> > important thing.
> > 
> > On Sun, 22 May 2016 23:21:59 +0200 Joerg Bornkessel
> > <hd_brummy@gentoo.org> wrote:
> >   
> >> - -   local docfile - -   for docfile in README* HISTORY
> >> CHANGELOG; do - -       [[ -f ${docfile} ]] && dodoc ${docfile} +
> >> local commondoc=( README* HISTORY CHANGELOG ) +   for docfile in
> >> "${commondoc[@]}"; do +       if [[ ${EAPI} == "6" ]]; then +
> >> local DOCS="${DOCS} ${docfile}" +           [[ -f ${docfile} ]]
> >> && einstalldocs "${DOCS[@]}" +       else +           [[ -f
> >> ${docfile} ]] && dodoc ${docfile} +       fi  
> > 
> > I have no clue what you're trying to achieve ...  
> 
> 
> Oh please, forget this crap!
> After rereading einstalldocs, how it works and how is it to handle in
> .ebuild, here my simple rewrite to integrate it in EAPI=6
> 
> <snipp>
> 
>     if [[ ${EAPI} != [45] ]]; then
>         einstalldocs
>     else
>         local docfile
>             for docfile in README* HISTORY CHANGELOG; do
>                 [[ -f ${docfile} ]] && dodoc ${docfile}
>             done
>     fi
> 
> </snapp>
> 
> yepp, einstalldocs is supported in EAPI=5 from eutils.eclass too,
> but i will leave it untached as we use it in this way for EAPI=4,5
> since long time.
> So we are save in the existing eapi=4,5 supported ebuilds in the tree.
> 
> Thanks for your review and reply

Yes, this looks good (except for the misindent). Thanks a lot.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]