[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev][PATCH V2] dev-lang/go-1.6.2: enable go-bootstrap tarball for ppc64le #581278
From:       Leno Hou <lenohou () gmail ! com>
Date:       2016-04-28 10:36:09
Message-ID: CAGQVrL-6MXG5UHXZsvPy6N+i-c18zkBDMq5NMBR2rYTWSxv2xw () mail ! gmail ! com
[Download RAW message or body]

On Thu, Apr 28, 2016 at 4:14 PM, Michał Górny <mgorny@gentoo.org> wrote:

> On Thu, 28 Apr 2016 05:59:14 +0000
> Leno Hou <lenohou@gmail.com> wrote:
>
> > There is a bootstrap tarball for ppc64le now, and  we have bi-arch
> > support for ppc64 platform. It's means that we can build go-1.6.2
> > without gccgo.
> >
> > Signed-off-by: Leno Hou <lenohou@gmail.com>
> > CC: William Hubbs <williamh@gentoo.org>
> > ---
> >  dev-lang/go/go-1.6.2.ebuild | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/dev-lang/go/go-1.6.2.ebuild b/dev-lang/go/go-1.6.2.ebuild
> > index 57ca2c7..049973a 100644
> > --- a/dev-lang/go/go-1.6.2.ebuild
> > +++ b/dev-lang/go/go-1.6.2.ebuild
> > @@ -88,6 +88,7 @@ go_arch()
> >       case "${portage_arch}" in
> >               x86)    echo 386;;
> >               x64-*)  echo amd64;;
> > +             ppc64)  [[ "$(tc-endian $@)" == "big" ]] || echo ppc64le;;
>
> Shouldn't this also have '&& echo ppc64'? Otherwise, on BE ppc64 there
> will be no output.
>

That's true. You're right.  So the next PATCH v3 will be sent.
-Leno Hou

[Attachment #3 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 28, \
2016 at 4:14 PM, Michał Górny <span dir="ltr">&lt;<a \
href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">On Thu, 28 Apr 2016 05:59:14 +0000<br> \
Leno Hou &lt;<a href="mailto:lenohou@gmail.com">lenohou@gmail.com</a>&gt; wrote:<br> \
<br> &gt; There is a bootstrap tarball for ppc64le now, and   we have bi-arch<br>
&gt; support for ppc64 platform. It&#39;s means that we can build go-1.6.2<br>
&gt; without gccgo.<br>
&gt;<br>
&gt; Signed-off-by: Leno Hou &lt;<a \
href="mailto:lenohou@gmail.com">lenohou@gmail.com</a>&gt;<br> &gt; CC: William Hubbs \
&lt;<a href="mailto:williamh@gentoo.org">williamh@gentoo.org</a>&gt;<br> &gt; ---<br>
&gt;   dev-lang/go/go-1.6.2.ebuild | 1 +<br>
&gt;   1 file changed, 1 insertion(+)<br>
&gt;<br>
&gt; diff --git a/dev-lang/go/go-1.6.2.ebuild b/dev-lang/go/go-1.6.2.ebuild<br>
&gt; index 57ca2c7..049973a 100644<br>
&gt; --- a/dev-lang/go/go-1.6.2.ebuild<br>
&gt; +++ b/dev-lang/go/go-1.6.2.ebuild<br>
&gt; @@ -88,6 +88,7 @@ go_arch()<br>
&gt;           case &quot;${portage_arch}&quot; in<br>
&gt;                       x86)      echo 386;;<br>
&gt;                       x64-*)   echo amd64;;<br>
&gt; +                    ppc64)   [[ &quot;$(tc-endian $@)&quot; == &quot;big&quot; \
]] || echo ppc64le;;<br> <br>
</span>Shouldn&#39;t this also have &#39;&amp;&amp; echo ppc64&#39;? Otherwise, on BE \
ppc64 there<br> will be no output.<br></blockquote><div><br></div><div>That&#39;s \
true. You&#39;re right.   So the next PATCH v3 will be sent.</div><div>-Leno Hou  \
<br></div></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]