[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] latex-package.eclass: Support EAPI 6.
From:       Dean Stephens <desultory () gentoo ! org>
Date:       2016-01-30 2:46:40
Message-ID: 56AC2410.1040509 () gentoo ! org
[Download RAW message or body]

On 01/27/16 14:59, Ulrich Mueller wrote:
> -# @FUNCTION: latex-package_has_tetex3 -# @RETURN: true if at
> least one of (>=tetex-3 or >=ptex-3.1.8 or >=texlive-core-2007) is 
> installed, else false -# @DESCRIPTION: -# It is often used to know 
> if the current TeX installation supports gentoo's -# texmf-update 
> or if the package has to do it the old way 
> -latex-package_has_tetex_3() { -	if has_version 
> '>=app-text/tetex-3' || has_version '>=app-text/ptex-3.1.8' || 
> has_version '>=app-text/texlive-core-2007' ; then -		true -	else - 
> false -	fi -} +case ${EAPI:-0} in +	0|1|2|3|4|5) +		# Kept for 
> backwards compatibility +		latex-package_has_tetex_3() { true; } + 
> ;; +esac
> 
Why remove the preexisting comment marked up for documentation
generation which indicated what it did and why, and stub it out with a
generically uninformative comment instead of just adding a deprecation
notice and literally one line of text to indicate why it was
deprecated and stubbed out? I am not taking issue with the change to
the code itself, just the removal of documentation in it.

[prev in list] [next in list] [prev in thread] [next in thread]