[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0
From:       "Justin Lecher (jlec)" <jlec () gentoo ! org>
Date:       2016-01-26 14:25:46
Message-ID: 56A781EA.9080501 () gentoo ! org
[Download RAW message or body]

On 26/01/16 15:10, Davide Pesavento wrote:
> On Tue, Jan 26, 2016 at 1:50 PM, Michał Górny <mgorny@gentoo.org> wrote:
>> Dnia 26 stycznia 2016 13:36:00 CET, Davide Pesavento <pesa@gentoo.org> napisał(a):
>>> On Mon, Jan 25, 2016 at 9:29 PM, Justin Lecher <jlec@gentoo.org> wrote:
>>>> Signed-off-by: Justin Lecher <jlec@gentoo.org>
>>>> ---
>>>>  eclass/cmake-utils.eclass | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
>>>> index 01de9a5..23339ab 100644
>>>> --- a/eclass/cmake-utils.eclass
>>>> +++ b/eclass/cmake-utils.eclass
>>>> @@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1
>>>>  # for econf and is needed to pass TRY_RUN results when
>>> cross-compiling.
>>>>  # Should be set by user in a per-package basis in
>>> /etc/portage/package.env.
>>>>
>>>> -case ${EAPI} in
>>>> +case ${EAPI:-0} in
>>>>         2|3|4|5|6) : ;;
>>>>         *) die "EAPI=${EAPI:-0} is not supported" ;;
>>>>  esac
>>>> --
>>>> 2.7.0
>>>>
>>>
>>> Why?
>>
>> Indeed, why? I think it would be cleaner to simply quote the parameter to case.
>>
> 
> AFAIK even quoting would be unnecessary in this context (assuming bash).
> 

Guys, if you are sure, that it is enough, then I will drop it. I just
thought there has to be something. But I tested it and it's unnecessary.
At least with latest bash.

Justin

[prev in list] [next in list] [prev in thread] [next in thread]