[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 10/15] perl-module.eclass: Rename SRC_TEST to DIST_TEST in EAPI=6 and defaul
From:       "Andreas K. Huettel" <dilfridge () gentoo ! org>
Date:       2015-12-27 11:37:25
Message-ID: 201512271237.31603.dilfridge () gentoo ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Am Samstag, 26. Dezember 2015, 12:53:20 schrieb Jeroen Roovers:
> On Fri, 11 Dec 2015 22:03:06 +0100
> 
> dilfridge@gentoo.org wrote:
> > From: "Andreas K. Huettel (dilfridge)" <dilfridge@gentoo.org>
> > 
> > ---
> > 
> >  eclass/perl-module.eclass | 40
> > 
> > +++++++++++++++++++++++----------------- 1 file changed, 23
> > insertions(+), 17 deletions(-)
> > 
> > diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
> > index efcc47c..0d428d2 100644
> > --- a/eclass/perl-module.eclass
> > +++ b/eclass/perl-module.eclass
> > @@ -154,6 +154,8 @@ if [[ ${EAPI:-0} = 5 ]] ; then
> > 
> >  		
SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR
> >  		:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:
+${MODULE_SECTION}/}${MODULE_A
> >  		}"
> >  	
> >  	[[ -z "${HOMEPAGE}" ]] && \
> >  	
> >  		HOMEPAGE="http://search.cpan.org/dist/${MODULE_NAME}/"
> > 
> > +
> > +	SRC_TEST="skip"
> > 
> >  else
> >  
> >  	DIST_NAME=${DIST_NAME:-${PN}}
> >  	DIST_P=${DIST_NAME}-${DIST_VERSION:-${PV}}
> > 
> > @@ -168,7 +170,6 @@ else
> > 
> >  fi
> 
> You're disabling src_test() by default in any ebuild that happens to
> inherit perl-module. Everyone who wants a way around that has to set
> STUPID_VARIABLE now. Why?
> 

That's the current (EAPI=5) behaviour, which has been unchanged in perl-
module.eclass since before I joined Gentoo afaik... I'm not too enthusiastic 
about it. 

EAPI=6 behaviour is the reverse; testing is enabled unless the variable 
DIST_TEST is set (and the variable allows more finetuning).

- -- 
Andreas K. Huettel
Gentoo Linux developer (council, perl, libreoffice)
dilfridge@gentoo.org
http://www.akhuettel.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWf811AAoJEHRrah2soMK+qhcP/2jKg70ic2XcGvdJnnsk/yuD
EJwE1dxlsSWBrTd01E71hbBcujJfHQQwslKtumU1TZ/a5uAF6jpEJXuxWtz/vV9U
XvNJuCjFhnKndWJxL3AiygbLNqk+R7ddOS5B2Pm2q/EV8PdSpVDhOX7qrmWQWWvL
dXekoN0ALTo5q+G/AKXddC/H4cu63V2ES4tjcVoc7dTVnXkiPD9oRTRYyPA3lG44
LCwIx3wVBO61Bu24DqvUqume/6obRp+ort3feM/mlGGxiOyYKSnlSHcOvcEw5FSg
stcF5urVRueiBTk8hHJVHHVttxwLRwrEGWL5849DgK3WZp1JMDRSrWmin93S6ur2
YXIbpxCm73ZwSXBJA74kcAh/CN3MVZf60ZIi/z3GdZE4pJU4zYRVlmd5AOVz3V4n
G0cGruJ2qtlFqinOxrrkj6/EKE7N4cjTN70nUggHKu4ApID8sd783uIbizs9+1Zs
0ZCCnj9EO28nIRmJhr8UfawVK0hQvZ14gGN/90D07bC1GIZeMFnd1aePIRz/bABN
eeI3OhhPI+yIlMKkRryT2RMi9lthUH9kIe+wEL9QnyCEjFlZsOhhl/e+m3lutfsF
E/AQ6WwzCrVpkjn1xkdrpKlZqjlzPXuQJv8irO9H/9IvViGvzxhF/+RO3Y6Cr/d3
ZqpUljJsvlT1Ob8/om55
=bJFY
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]