[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 3/5] app-emulation/xen-tools: Make use of new python_gen_impl_dep function
From:       Doug Goldstein <cardoe () gentoo ! org>
Date:       2015-12-24 16:21:56
Message-ID: 567C1BA4.4040801 () gentoo ! org
[Download RAW message or body]


On 12/23/15 10:44 AM, Michał Górny wrote:
> ---
> app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild | 2 +-
> app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild | 2 +-
> app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild  | 4 ++--
> app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild  | 4 ++--
> app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild  | 2 +-
> app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild  | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild index 67e3d1c..d29aab3 100644
> --- a/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild
> @@ -68,7 +68,7 @@ DEPEND="dev-libs/lzo:2
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> 	${PYTHON_DEPS}
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> 	sys-devel/bin86
> 	sys-devel/dev86
> 	dev-lang/perl
> diff --git a/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild index ae93f4d..392be10 100644
> --- a/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild
> @@ -68,7 +68,7 @@ DEPEND="dev-libs/lzo:2
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> 	${PYTHON_DEPS}
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> 	sys-devel/bin86
> 	sys-devel/dev86
> 	dev-lang/perl
> diff --git a/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild index 8af652c..ba2f756 100644
> --- a/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild
> @@ -87,8 +87,8 @@ DEPEND="${COMMON_DEPEND}
> 	${PYTHON_DEPS}
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
> 	!amd64? ( >=sys-apps/dtc-1.4.0 )
> 	amd64? ( sys-devel/bin86
> 		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild index 59e9056..a147169 100644
> --- a/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild
> @@ -90,8 +90,8 @@ DEPEND="${COMMON_DEPEND}
> 	${PYTHON_DEPS}
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
> 	!amd64? ( >=sys-apps/dtc-1.4.0 )
> 	amd64? ( sys-devel/bin86
> 		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild index 57d618e..e9f84c0 100644
> --- a/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild
> @@ -87,7 +87,7 @@ DEPEND="${COMMON_DEPEND}
> 	${PYTHON_DEPS}
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
> 	!amd64? ( >=sys-apps/dtc-1.4.0 )
> 	amd64? ( sys-devel/bin86
> 		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild \
> b/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild index 104fac9..ceb1402 100644
> --- a/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild
> @@ -90,7 +90,7 @@ DEPEND="${COMMON_DEPEND}
> 	${PYTHON_DEPS}
> 	api? ( dev-libs/libxml2
> 		net-misc/curl )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
> 	!amd64? ( >=sys-apps/dtc-1.4.0 )
> 	amd64? ( sys-devel/bin86
> 		system-seabios? ( sys-firmware/seabios )
> 

Acked-by: Doug Goldstein <cardoe@cardoe.com>

I actually made ncurses always required in recent versions to try and
avoid this hack. I'm glad there's a nicer way to officially do this.

-- 
Doug Goldstein


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]