[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()
From:       Davide Pesavento <pesa () gentoo ! org>
Date:       2015-11-30 17:40:12
Message-ID: CADfzvvaiKdC_OF40=aQ6md7JYnn+nLcyr6HfvBQuz4PZtFR=0Q () mail ! gmail ! com
[Download RAW message or body]

On Sat, Nov 28, 2015 at 4:50 PM, Justin Lecher (jlec) <jlec@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 28/11/15 16:28, Davide Pesavento wrote:
>>> else -               nonfatal ${VIRTUALX_COMMAND} "$@" +
>>> nonfatal "$@"
>>
>> Please take the opportunity to clean this up, possibly only in
>> EAPI=6 if you don't want to risk breaking existing ebuilds. See bug
>> 517976 for details.
>>
>>> retval=$?
>
> The return value is recorded and gets evaluated correctly.
>
> src_test() {
>         virtx false
> }
>
[...]
>
> Am I missing something?

The scenario of bug 517976 is different. I think a minimized test case
is the following (untested):

foo() {
    die "meh"
    return 0
}

src_test() {
    virtx foo
}

[prev in list] [next in list] [prev in thread] [next in thread]