[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] vcs-snapshot.eclass: add a way to specify the extraction path
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2015-07-31 1:53:29
Message-ID: 20150731035329.1a571a66 () pomiot
[Download RAW message or body]


Dnia 2015-07-30, o godz. 10:57:46
William Hubbs <williamh@gentoo.org> napisał(a):

> All,
> 
> I'm finding in working on Go ebuilds, that we are propegating a
> src_unpack function that is very similar to the one in vcs-snapshot.
> 
> This patch adds an EXTRACT_PATH variable to the vcs-snapshot eclass
> which, if set, puts the extracted archives in the specified directory under ${S}.
> 
> If it is not set, nothing should happen.
> 
> This could be used by other types of ebuilds later, but for now it would
> be used by Go ebuilds.
> 
> Thoughts?

I'm against it. This doubles the eclass code, adding completely
orthogonal and incompatible behavior.

The goal of this eclass is to provide a relatively simple way of
extracting VCS snapshots and putting them in a predictable locations,
not fitting some random src_unpack() you happen to use.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]