[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: ChangeLog golang-build.eclass
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2015-06-25 3:49:00
Message-ID: 20150625054900.1f9ec250 () pomiot
[Download RAW message or body]


Dnia 2015-06-24, o godz. 16:04:39
William Hubbs <williamh@gentoo.org> napisał(a):

> On Wed, Jun 24, 2015 at 07:02:49PM +0200, Michał Górny wrote:
> > Dnia 2015-06-24, o godz. 11:51:44
> > William Hubbs <williamh@gentoo.org> napisał(a):
> > 
> > > On Wed, Jun 24, 2015 at 05:54:31PM +0200, Michał Górny wrote:
> > > > Dnia 2015-06-24, o godz. 15:38:34
> > > > "William Hubbs (williamh)" <williamh@gentoo.org> napisał(a):
> > > 
> > > *snip*
> > > 
> > > > > # @FUNCTION: _golang-build_setup
> > > > > # @INTERNAL
> > > > > # @DESCRIPTION:
> > > > > # Make sure EGO_PN has a value.
> > > > > _golang-build_setup() {
> > > > > 	[ -z "${EGO_PN}" ] &&
> > > > 
> > > > Please don't use 'unsafe' single brackets. Use bash's double brackets,
> > > > i.e. [[ -z ${EGO_PN} ]].
> > > 
> > > Ok, this will be fixed.
> > > 
> > > > > golang-build_src_compile() {
> > > > > 	debug-print-function ${FUNCNAME} "$@"
> > > > > 
> > > > > 	_golang-build_setup
> > > > > 	set -- env GOPATH="${WORKDIR}/${P}:${EPREFIX}/usr/lib/go-gentoo" \
> > > > > 		go build -v -work -x "${EGO_PN}"
> > > > > 	echo "$@"
> > > > 
> > > > I suggest to push this to stderr, >&2.
> > > 
> > > Why? this is just printing the command before we run it. Do Make, etc
> > > print this output to stderr?
> > 
> > This is pretty much a debugging output which doesn't belong besides
> > regular output. Make doesn't, bash does.
> 
> My concern is, if the go tools themselves put some output on stdout and
> some on stderr and I redirect everything to stderr, that could break
> upstream behaviour, and I would rather not do that.

I mean only the echo, not the command itself.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]