[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] new eclass: go-live.eclass for handling go live ebuilds
From:       William Hubbs <williamh () gentoo ! org>
Date:       2015-06-16 21:03:15
Message-ID: 20150616210315.GA26031 () linux1 ! gaikai ! biz
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


There have been no more comments on this eclass.

I did, however, find some typos that I fixed. I will attach the patch
with the fixes here then commit the eclass. Without these fixes the
eclass generates "command not found" errors.

The fixes involve s/umask_push/eumask_push/ and s/umask_pop/eumask_pop/.

William


["golang-vcs-fixes.patch" (text/x-diff)]

--- a/golang-vcs.eclass	2015-06-16 15:00:31.995528578 -0500
+++ b/golang-vcs.eclass	2015-06-16 14:47:00.484815701 -0500
@@ -72,7 +72,7 @@
 	local distdir=${PORTAGE_ACTUAL_DISTDIR:-${DISTDIR}}
 	: ${EGO_STORE_DIR:=${distdir}/go-src}
 
-	[[ -n ${EVCS_UMASK} ]] && umask_push $EVCS_UMASK
+	[[ -n ${EVCS_UMASK} ]] && eumask_push $EVCS_UMASK
 
 	if [[ ! -d ${EGO_STORE_DIR} ]]; then
 		(
@@ -84,7 +84,7 @@
 	addwrite "${EGO_STORE_DIR}"
 	export GOPATH="${EGO_STORE_DIR}"
 
-	[[ -n ${EVCS_UMASK} ]] && umask_pop
+	[[ -n ${EVCS_UMASK} ]] && eumask_pop
 	mkdir -p "${S}" ||
 		die "${ECLASS}: unable to create ${S}"
 	return 0
@@ -105,7 +105,7 @@
 		return 0
 	fi
 
-	[[ -n ${EVCS_UMASK} ]] && umask_push ${EVCS_UMASK}
+	[[ -n ${EVCS_UMASK} ]] && eumask_push ${EVCS_UMASK}
 
 	set -- go get -d -t -u -v -x "${EGO_PN}"
 	echo "$@"
@@ -117,7 +117,7 @@
 	# I am hoping this will be fixed so "go get -d" is successful if
 	# downloading the top level repository is successful.
 
-	[[ -n ${EVCS_UMASK} ]] && umask_pop
+	[[ -n ${EVCS_UMASK} ]] && eumask_pop
 	export GOPATH="${S}:${EGO_STORE_DIR}"
 	return 0
 }

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]