[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] RFC: kde5 and kde5-functions eclass
From:       Davide Pesavento <pesa () gentoo ! org>
Date:       2014-09-19 21:52:47
Message-ID: CADfzvvYKaLBKDGCwUK7hPS9+tGVW91ZHaWTfN38VF-Vi4Kp7oQ () mail ! gmail ! com
[Download RAW message or body]

kde5.eclass

> case ${KDE_TEST} in
> false) ;;
> *)
> IUSE+=" test"
> DEPEND+=" test? ( dev-qt/qttest:5 )"

No >=${QT_MINIMAL} in this dep?

> else
> unpack ${A}

I think you can use `default`

> if ! in_iuse examples || ! use examples ; then

if ! use_if_iuse examples ; then

> if ! in_iuse test || ! use test ; then

ditto

> if [ -n "${DBUS_SESSION_BUS_PID}" ] ; then

Use [[ ]], and you can also omit quoting.

> dohtml -r ${P}-apidocs/html/*

docinto html
dodoc -r ${P}-apidocs/html/*

Or even shorter, dodoc -r ${P}-apidocs/html (without docinto)

Thanks,
Davide

[Attachment #3 (text/html)]

<div dir="ltr">kde5.eclass<div><br></div><div><div>&gt; case ${KDE_TEST} \
in</div><div><span class="" style="white-space:pre">&gt; 	</span>false)<span class="" \
style="white-space:pre">	</span>;;</div><div><span class="" \
style="white-space:pre">&gt; 	</span>*)</div><div><span class="" \
style="white-space:pre">&gt; 		</span>IUSE+=&quot; test&quot;</div><div><span \
class="" style="white-space:pre">&gt; 		</span>DEPEND+=&quot; test? ( dev-qt/qttest:5 \
)&quot;</div></div><div><br></div><div>No &gt;=${QT_MINIMAL} in this \
dep?</div><div><br></div><div><div><span class="" \
style="white-space:pre">&gt;	</span>else</div><div><span class="" \
style="white-space:pre">&gt;		</span>unpack ${A}</div></div><div><br></div><div>I \
think you can use `default`</div><div><br></div><div><div><span class="" \
style="white-space:pre">&gt;	</span>if ! in_iuse examples || ! use examples ; \
then</div></div><div><br></div><div>if ! use_if_iuse examples ; \
then</div><div><br></div><div><div><span class="" \
style="white-space:pre">&gt;	</span>if ! in_iuse test || ! use test ; \
then</div></div><div><br></div><div>ditto</div><div><br></div><div><div><span \
class="" style="white-space:pre">&gt;	</span>if [ -n \
&quot;${DBUS_SESSION_BUS_PID}&quot; ] ; then</div></div><div><br></div><div>Use [[ \
]], and you can also omit quoting.</div><div><br></div><div><div><span class="" \
style="white-space:pre">&gt;		</span>dohtml -r \
${P}-apidocs/html/*</div></div><div><br></div><div>docinto html</div><div>dodoc -r \
${P}-apidocs/html/*</div><div><br></div><div>Or even shorter, dodoc -r \
${P}-apidocs/html (without \
docinto)</div><div><br></div><div>Thanks,</div><div>Davide</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]