[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] rfc: calling all eclass phase functions by default
From:       Rich Freeman <rich0 () gentoo ! org>
Date:       2014-08-18 10:44:59
Message-ID: CAGfcS_=7PQRrvay_tojnrxRz5wRCCbPD9Oyd4rJuYMhKki8bmQ () mail ! gmail ! com
[Download RAW message or body]

On Mon, Aug 18, 2014 at 4:54 AM, Sergey Popov <pinkbyte@gentoo.org> wrote:
> 17.08.2014 01:54, William Hubbs пишет:
>>
>> # Foo and bar both have src_unpack and src_install functions.
>> # we want foo's src_unpack and bar's src_install:
>>
>> ECLASS_PHASES="foo_src_unpack
>>       bar_src_install"
>
> You have my strong opposition on such change as well. It will turn
> ebuilds into unreadable and undpredictable mess, please do not do that
>

I'm not sure I follow your complaint.  He is talking about adding one
line to an ebuild.  I'm not sure how that is unreadable, and the
algorithm you quoted looks fairly predictable to me as well.

Certainly it is less convenient than not having to do anything to pull
in eclass-defined phase functions, and it requires ebuilds to be
updated when eclasses are updated to add new phase functions.  That
could be problematic for cases like KDE/X11/etc where you have a large
collection of short ebuilds with all the logic in an eclass.

I just want to make sure I'm understanding your concern in case there
is a new issue being raised.

Rich

[prev in list] [next in list] [prev in thread] [next in thread]