[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/mysql: mysql-5.1.73-r1.ebuild Chan
From:       "Justin (jlec)" <jlec () gentoo ! org>
Date:       2014-05-14 7:00:04
Message-ID: 53731474.3060005 () gentoo ! org
[Download RAW message or body]


On 14/05/14 08:56, Justin (jlec) wrote:
> On 14/05/14 03:47, Brian Evans (grknight) wrote:
> 
> Hi Brian,
> 
>> EAPI="4"
> 
> please always try to bump to latest EAPI when ever you add a new
> revision or version to the tree,
> 
> 
>> # Most of these are in the eclass
>> DEPEND="|| ( >=sys-devel/gcc-3.4.6 >=sys-devel/gcc-apple-4.0 )
>> 		>=sys-devel/libtool-2.2.10"
> 
> As you wrote correctly in your quizzes, depending is not enough. You
> also need to test to those compilers.
> 
>> src_prepare() {
>> 	sed -i \
>> 		-e '/^noinst_PROGRAMS/s/basic-t//g' \
>> 		"${S}"/unittest/mytap/t/Makefile.am
> 
> missing die for external tools.
> 
>> 	emake check || die "make check failed"
> 
> no die needed for emake in higher EAPIs.
> 
>> 		cd "${S}"
> 
> same here
> 
>> 		# create directories because mysqladmin might make out of order
>> 		mkdir -p "${S}"/mysql-test/var-{ps,ns}{,/log}
> 
> here
> 
> 
> 
> Justin
> 

Please everyone forget this. This wasn't meant for public.

Justin


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]