[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH subversion.eclass] Export working copy information after the update.
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2013-07-27 10:18:53
Message-ID: 20130727121853.21778d1c () gentoo ! org
[Download RAW message or body]


Dnia 2013-07-23, o godz. 20:46:15
Michał Górny <mgorny@gentoo.org> napisał(a):

> Currently, subversion.eclass exports working working copy information
> such as ESVN_WC_REVISION two times: once before running 'svn up',
> and the second time in pkg_preinst(). As a result, between those two
> calls ESVN_WC_REVISION lists the *previous* working copy revision rather
> than the current one.
> 
> This behavior is not exploited by any ebuild. Instead, all ebuilds that
> use ESVN_WC_REVISION either hack it around, or actually use the wrong
> revision mistakenly.
> 
> The patch fixes the eclass to export working copy information *after*
> the update is done. Redundant call to subversion_wc_info is removed from
> pkg_preinst() as no ebuild needs the re-export.
> 
> Fixes: https://bugs.gentoo.org/show_bug.cgi?id=282486

Committed.

-- 
Best regards,
Michał Górny

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]