[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Proposed update to pax-utils.eclass
From:       Alec Warner <antarus () gentoo ! org>
Date:       2013-03-27 15:22:12
Message-ID: CAAr7Pr_y3VNtmRHRK0sY0Jsaw5VEUwGy-D0WYOXsPrx2RAxdZA () mail ! gmail ! com
[Download RAW message or body]

On Wed, Mar 27, 2013 at 5:39 AM, Gilles Dartiguelongue <eva@gentoo.org> wro=
te:
> Le dimanche 24 mars 2013 =C3=A0 20:20 -0400, Anthony G. Basile a =C3=A9cr=
it :
>> Last call, does anyone have a problem with me updating the
>> pax-utils.eclass?  See Ref [3] above for the code.  I'll wait a couple
>> more days and then do it.
>
> looks like last conditional branch for XT marking in pax-mark function
> is not using the proper variables (pt_* instead ot xt_*).
>
> The PAX_MARKINGS variable is not documented with eclass documentation
> markup, it should at least get an "@INTERNAL" if this is not supposed to
> be modified by eclass users.
>
> _pax_list_files can receive documentation this way as well.
>
> You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ]
> seems to be less used here so just have everything [[ ]] and drop the
> useless quoting that came with [ ].

You should never use [ in the tree.

-A

>
> The rest looks fine.
>
> --
> Gilles Dartiguelongue <eva@gentoo.org>
> Gentoo
>
>

[prev in list] [next in list] [prev in thread] [next in thread]