[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] Re: [PATCH eutils] Die if epunt_cxx is called unnecessarily.
From:       Ryan Hill <dirtyepic () gentoo ! org>
Date:       2013-01-31 0:17:46
Message-ID: 20130130181746.01bbbb1e () caribou ! gateway ! 2wire ! net
[Download RAW message or body]


On Thu, 31 Jan 2013 00:53:06 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> On Wed, 30 Jan 2013 17:57:20 -0600
> Ryan Hill <dirtyepic@gentoo.org> wrote:

> > On Wed, 30 Jan 2013 22:36:53 +0100
> > Michał Górny <mgorny@gentoo.org> wrote:

> > > Currently, epunt_cxx always succeeds. This results in some
> > > of the ebuilds keeping its use even though the C++ checks were removed
> > > upstream.
> > > 
> > > Therefore, I'm suggesting to add a simple check to the function -- if
> > > none of the patching attempts succeed, die requesting the user to remove
> > > the invocation.
> > 
> > eqawarn?
> 
> Yes, eqawarn if we don't want users to be hurt :P.

I think it would be overkill to make what is essentially a no-op into a fatal
error.  A warning would be appropriate.


-- 
gcc-porting
toolchain, wxwidgets            learn a language baby, it's that kind of place
@ gentoo.org                   where low card is hunger and high card is taste

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]