[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2013-01-28 9:25:28
Message-ID: 20130128102528.5aac5a38 () pomiocik ! lan
[Download RAW message or body]


On Sun, 27 Jan 2013 20:27:06 -0300
Alexis Ballier <aballier@gentoo.org> wrote:

> On Sun, 27 Jan 2013 23:46:06 +0100
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > Alexis,
> > 
> > Following your remark, I have redesigned the loop to use MULTILIB_ABIS
> > list to order the ABIs. This should ensure the most valid replacement
> > order.
> 
> Great, that's better than what I had thought about
> 
> > Additionally, I have added an assertion to ensure that DEFAULT_ABI
> > comes last in MULTILIB_ABIS list.
> 
> I'm not sure it is a good idea: it is certainly safe, but this removes
> the flexibility not to build for the DEFAULT_ABI. Not sure if it's
> sane to do so or if there is any usecase either, but since get_all_abis
> ensures us DEFAULT_ABI is last I don't see a need to double check it
> here.

Well, you are probably right. No point in being more strict than
multilib.eclass.

-- 
Best regards,
Michał Górny

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]