[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] RFC: trivial chromium.eclass patch
From:       "Paweł Hajdan, Jr." <phajdan.jr () gentoo ! org>
Date:       2012-05-29 8:47:08
Message-ID: 4FC48D0C.5070806 () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


I'd like to commit the following chromium.eclass patch.

The rationale is that checked kernel config options are not needed for
SELinux sandbox.

After that patch gets committed, I plan to modify the ebuilds in tree.
Can the deprecated function be removed immediately after that, or should
it stay longer? If the latter, how long?

It seems gentoo-dev review is not strictly needed for non-general
eclasses (<http://devmanual.gentoo.org/eclass-writing/index.html>), but
I'd just make sure I'm making those changes correctly.

Pawe=C5=82

["chromium.patch" (text/plain)]

--- chromium.eclass.orig	2012-05-29 10:33:45.000000000 +0200
+++ chromium.eclass	2012-05-29 10:36:59.000000000 +0200
@@ -17,11 +17,11 @@
 	IUSE+=" custom-cflags"
 fi
 
-# @FUNCTION: chromium_check_kernel_config
+# @FUNCTION: chromium_suid_sandbox_check_kernel_config
 # @USAGE:
 # @DESCRIPTION:
-# Ensures the system kernel is configured for full Chromium functionality.
-chromium_check_kernel_config() {
+# Ensures the system kernel supports features needed for SUID sandbox to work.
+chromium_suid_sandbox_check_kernel_config() {
 	has "${EAPI:-0}" 0 1 2 3 && die "EAPI=${EAPI} is not supported"
 
 	if [[ "${MERGE_TYPE}" == "source" || "${MERGE_TYPE}" == "binary" ]]; then
@@ -34,6 +34,16 @@
 	fi
 }
 
+# @FUNCTION: chromium_check_kernel_config
+# @USAGE:
+# @DESCRIPTION:
+# Ensures the system kernel is configured for full Chromium functionality.
+chromium_check_kernel_config() {
+	eqawarn "chromium_check_kernel_config is deprecated."
+	eqawarn "Please use chromium_suid_sandbox_check_kernel_config if applicable."
+	chromium_suid_sandbox_check_kernel_config
+}
+
 # @ECLASS-VARIABLE: CHROMIUM_LANGS
 # @DEFAULT_UNSET
 # @DESCRIPTION:

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]