[prev in list] [next in list] [prev in thread] [next in thread]
List: gentoo-dev
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
From: Justin <jlec () gentoo ! org>
Date: 2012-02-22 18:43:36
Message-ID: 4F453758.1020304 () gentoo ! org
[Download RAW message or body]
On 22.02.2012 18:33, Matthew Summers wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
>> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
>>> Hi,
>>>
>>> any objections against following patch for subversion.eclass?
>>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
>>> reemerge of a package.
>>>
>>>
>>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
>>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
>>> @@ -469,7 +469,9 @@
>>> local target="${1}"
>>> local key="${2}"
>>>
>>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> + env LC_ALL=C svn info \
>>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
>>> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> }
>>>
>>> ## -- subversion__get_repository_uri()
>>> --------------------------------------- #
>>
>> I'm not an expert of the subversion eclass, but the diff looks good.
>>
>> --
>> Gilles Dartiguelongue <eva@gentoo.org>
>> Gentoo
>
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.
>
This one for example
http://rapidsvn.tigris.org/
Quote:
Now you can checkout the source code for RapidSVN with RapidSVN
(Repository->Checkout) or with the svn command-line client.
The URL for the latest code is:
http://rapidsvn.tigris.org/svn/rapidsvn/trunk
You will be prompted for username and password.
For read access enter "guest" with an empty password.
justin
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic