[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH git-2.eclass 1/2] Clean up non-bare
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2011-12-23 21:49:46
Message-ID: 20111223224946.14ac4443 () pomiocik ! lan
[Download RAW message or body]


On Fri, 23 Dec 2011 22:09:26 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Fri, 23 Dec 2011, Michał Górny wrote:
> 
> > Fixes: https://bugs.gentoo.org/show_bug.cgi?id=395247
> 
> > +		git clean -d -f -x || die "${FUNCNAME}: failed to
> > clean checkout dir" +
> 
> Why should there be untracked files, in the first place? (In the
> "steps to reproduce" of bug 395247 such files are explicitly generated
> by the user, which doesn't look like a valid usage case to me.)

Yes, it is invalid. Yet I think it's better to clean up just in case
upstream pulling gone wrong (e.g. when upstream does rebase).

-- 
Best regards,
Michał Górny

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]