[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Re: proj/portage:master commit in: pym/portage/dbapi/
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2011-11-30 20:31:14
Message-ID: 201111301531.14947.vapier () gentoo ! org
[Download RAW message or body]


On Sunday 27 November 2011 17:28:12 Arfrever Frehtes Taifersar Arahesis wrote:
> 2011-11-26 11:58:22 Fabian Groffen napisał(a):
> > On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
> > > commit:     1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
> > > T> Org>
> > > AuthorDate: Sat Nov 26 01:52:49 2011 +0000
> > > Commit:     Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo
> > > <DOT> org> CommitDate: Sat Nov 26 01:52:49 2011 +0000
> > > URL:       
> > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1
> > > d4ac47c
> > > 
> > > dblink.mergeme(): Merge files in alphabetic order.
> > 
> > What's the advantage of this?
> 
> The advantage is that this allows to easier review output of `emerge` to
> verify if correct files have been installed.

then you should be sorting the output and not the db

along these lines, if you're going to be making commits to important repos, 
please use changelogs that are actually useful.  the changelog here:
	dblink.mergeme(): Merge files in alphabetic order.
is utterly and completely useless.

you need to document *why* you're changing things first and foremost, and only 
then can you delve into details as to why the implementation you're committing 
makes sense.
-mike

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]