[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] repoman not complaining when going straight to stable
From:       Zac Medico <zmedico () gentoo ! org>
Date:       2011-11-29 16:09:06
Message-ID: 4ED503A2.5020502 () gentoo ! org
[Download RAW message or body]

On 11/29/2011 04:11 AM, "Paweł Hajdan, Jr." wrote:
> On 11/26/11 11:29 AM, Sergei Trofimovich wrote:
>> On Sat, 26 Nov 2011 10:15:53 +0100
>> ""Paweł Hajdan, Jr."" <phajdan.jr@gentoo.org> wrote:
>>
>>> This shouldn't be allowed, should it? The package is keyworded only
>>> ~x86, and I'm adding amd64 stable keyword, and repoman doesn't complain.
>>
>> It would need to fetch latest CVS file from server to check against previous state.
>> I don't think repoman does any network IO safe updating metadata.dtd.
> 
> Why does it warn about going straight to stable for _new_ ebuilds? Is it
> because it knows locally that it's a new file, and because of that
> doesn't need to connect to network? That'd make sense.

Right, repoman parses the files in the CVS directories to figure that out.

> Would it be possible to add repoman checks (possibly behind a special
> flag) that could use "cvs diff" results?

Sure, we can add an --allow-network option. That would also be useful
for checking SRC_URI in this bug:

  https://bugs.gentoo.org/show_bug.cgi?id=315243

We could also add fine-grained options if you want to enable/disable
specific checks that use the network and not others.
-- 
Thanks,
Zac

[prev in list] [next in list] [prev in thread] [next in thread]