[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] net-misc/pimd RFC for new ebuild
From:       Kfir Lavi <lavi.kfir () gmail ! com>
Date:       2011-07-20 10:46:56
Message-ID: CAHNvW1LYEEWCb-Jdr=t69t_CPQjLFF1wxUG7iGiHaRORMbPKOg () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jul 19, 2011 at 9:32 PM, Kacper Kowalik <xarthisius@gentoo.org>wrote:

> W dniu 19.07.2011 19:31, Donnie Berkholz pisze:
> > On 11:43 Sun 17 Jul     , Kacper Kowalik wrote:
> > > W dniu 17.07.2011 10:45, Kfir Lavi pisze:
> > > > src_compile() {
> > > > emake CC=$(tc-getCC) || die
> > > > }
> > > Some systems export CC as "gcc -m64".
> > 
> > I guess I'm a little confused here. What exactly is the problem and fix
> > you're proposing? You stopped halfway through, there should've been a
> > part at the end that said:
> > 
> > ", so you need to do XX to avoid YY from happening".
> 
> Use quotes: CC="$(tc-getCC)". Without it you could get emake CC=gcc -m64
> and that would of course fail.
> Apologies for mental leap...
> Cheers,
> Kacper
> 
> 
> As I posted before, I have new code for your review in the bug \
> 52848<https://bugs.gentoo.org/show_bug.cgi?id=352848>,
and it doesn't use CC="$(tc-getCC)"
anymore.

Thanks,
Kfir


[Attachment #3 (text/html)]

<div dir="ltr"><br><br><div class="gmail_quote">On Tue, Jul 19, 2011 at 9:32 PM, \
Kacper Kowalik <span dir="ltr">&lt;<a \
href="mailto:xarthisius@gentoo.org">xarthisius@gentoo.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

W dniu 19.07.2011 19:31, Donnie Berkholz pisze:<br>
<div class="im">&gt; On 11:43 Sun 17 Jul       , Kacper Kowalik wrote:<br>
&gt;&gt; W dniu 17.07.2011 10:45, Kfir Lavi pisze:<br>
&gt;&gt;&gt; src_compile() {<br>
&gt;&gt;&gt;       emake CC=$(tc-getCC) || die<br>
&gt;&gt;&gt; }<br>
&gt;&gt; Some systems export CC as &quot;gcc -m64&quot;.<br>
&gt;<br>
&gt; I guess I&#39;m a little confused here. What exactly is the problem and fix<br>
&gt; you&#39;re proposing? You stopped halfway through, there should&#39;ve been \
a<br> &gt; part at the end that said:<br>
&gt;<br>
&gt; &quot;, so you need to do XX to avoid YY from happening&quot;.<br>
<br>
</div>Use quotes: CC=&quot;$(tc-getCC)&quot;. Without it you could get emake CC=gcc \
-m64<br> and that would of course fail.<br>
Apologies for mental leap...<br>
Cheers,<br>
<font color="#888888">Kacper<br>
<br>
<br>
</font></blockquote></div>As I posted before, I have new code for your review in the \
bug <a href="https://bugs.gentoo.org/show_bug.cgi?id=352848" \
target="_blank">52848</a>, and it doesn&#39;t use CC=&quot;$(tc-getCC)&quot;<br>

anymore.<br><br>Thanks,<br>Kfir<br></div>



[prev in list] [next in list] [prev in thread] [next in thread]