[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2011-06-29 2:46:34
Message-ID: 201106282246.34794.vapier () gentoo ! org
[Download RAW message or body]


On Tuesday, June 28, 2011 15:58:46 Michał Górny wrote:
> On Tue, 28 Jun 2011 15:04:00 -0400 Nathan Phillip Brink wrote:
> > On Tue, Jun 28, 2011 at 10:24:26PM +0400, Peter Volkov wrote:
> > > ?? ??????, 28/06/2011 ?? 12:23 -0400, Mike Frysinger ??????????:
> > > > On Tuesday, June 28, 2011 02:54:03 Micha?? G??rny wrote:
> > > > > emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"...
> > > > 
> > > > this is easily dangerous when it comes to packages (and many do)
> > > > that append in the Makefile.  specifying on the command line
> > > > blocks those while passing via env works fine.  i'm not sure it's
> > > > appropriate to provide as an example.
> > > 
> > > Hm, I'm not sure I understand what you are talking about here.
> > > Could you provide example?
> > 
> > I think he's referring to somethine like:
> > 
> > Makefile:
> > CFLAGS += `pkg-config --cflags libxml-2.0`
> > 
> > which would work fine for:
> >   emake
> > 
> > but which would override the pkg-config flags if you do:
> >   emake CFLAGS="${CFLAGS}"
> 
> But is overriding really useful in this particular case? It seems
> rather irrelevant here.

if the Makefile starts off with
CFLAGS = <hardcode>

and then in subdirs it appends, then yes

or people split up the initial hardcode and latter pkg-config appends as 
Nathan showed, then yes
-mike

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]