[prev in list] [next in list] [prev in thread] [next in thread]
List: gentoo-dev
Subject: [gentoo-dev] Re: Major changes to gdesklets.eclass
From: Christian Faulhammer <fauli () gentoo ! org>
Date: 2009-12-29 8:54:58
Message-ID: 20091229095458.456afc15 () gentoo ! org
[Download RAW message or body]
Hi,
Joe Sapp <nixphoeni@gentoo.org>:
> Anyways, a diff would be useless so I've attached the proposed eclass
> [2].
Looks fine so far. What puzzled me is the documentation of the SLOT
variable. What is the motivation to do so?
* Sometimes you give a default on undefined ROOT variable, sometimes
not. Please make it consistent for cosmetic reasons.
* addwrite "${ROOT}/root/.gnome2": Is this unconditionally necessary?
Or could a "boolean" in the ebuild be set to activate it?
* DISPLAY variable export could be done with the assignment. Or is the
export always needed?
* Is the file name LICENSE always used for the license or is COPYING
for example also possible?
* einfo "Installing Control ${CTRL_DIRNAME}": Is not mirrored in the
desklet branch of the if clause.
V-Li
--=20
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
<URL:http://gentoo.faulhammer.org/>
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic