[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Please review: prefix.eclass
From:       Fabian Groffen <grobian () gentoo ! org>
Date:       2009-03-27 12:24:27
Message-ID: 20090327122427.GS15265 () gentoo ! org
[Download RAW message or body]

On 27-03-2009 13:08:46 +0100, Ulrich Mueller wrote:
> >>>>> On Fri, 27 Mar 2009, Fabian Groffen wrote:
> 
> > Please review.
> 
> >            r=$?
> >            eend ${r}
> >            [[ ${r} != 0 ]] && die "failed to eprefixify ${x}"
> 
> Here you could save a variable, since eend returns the status:

it wasn't even declared local, so double FAIL.

>     eend $? || die "failed to eprefixify ${x}"

Applied, thanks!


-- 
Fabian Groffen
Gentoo on a different level

[prev in list] [next in list] [prev in thread] [next in thread]