[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following
From:       Petteri Räty <betelgeuse () gentoo ! org>
Date:       2008-09-30 17:05:37
Message-ID: 48E25C61.7070805 () gentoo ! org
[Download RAW message or body]


Nirbheek Chauhan kirjoitti:
> On Sat, Sep 27, 2008 at 3:47 PM, Thomas Sachau <tommy@gentoo.org> wrote:
>> So what about this one?
>>
>> default_src_install() {
>>        if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
>>                emake DESTDIR="${D}" install || die "emake install failed"
>>        fi
>>        if [ -n "${DOCS}" ]; then
>>                dodoc ${DOCS} || die "dodoc failed"
>>        else
>>                # No die here because we don't know if any of these exist
>>                dodoc AUTHORS ChangeLog NEWS README
>>        fi
>> }
> 
> This seems alright fine to me
> 
> Cheers,
> 
> ~Nirbheek Chauhan
> 

It's not. If you want to have default DOCS then you should loop through 
the items and check with [[ -e ]] before trying to install them.

Regards,
Petteri


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]