[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in
From:       Donnie Berkholz <dberkholz () gentoo ! org>
Date:       2007-10-31 23:42:35
Message-ID: 20071031234235.GU30328 () supernova
[Download RAW message or body]

On 19:49 Wed 31 Oct     , Bernard Cafarelli (voyageur) wrote:
> 1.1                  net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&view=markup
>                 
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&content-type=text/plain
> 

> pkg_postinst () {
> 	usermod -s /usr/bin/nxserver nx || die "Unable to set login shell of nx user!!"
> 	usermod -d ${NX_HOME_DIR} nx || die "Unable to set home directory of nx user!!"

This isn't safe with ROOT != / and it looks wrong too, you oughta be 
using enewuser for this stuff.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list


[prev in list] [next in list] [prev in thread] [next in thread]