[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/sandbox: ChangeLog sandbox-1.2.1
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2007-10-29 11:57:24
Message-ID: 200710290757.25038.vapier () gentoo ! org
[Download RAW message or body]

On Thursday 18 October 2007, Alec Warner wrote:
> On 10/17/07, Doug Goldstein <cardoe@gentoo.org> wrote:
> > Donnie Berkholz wrote:
> > > On 15:55 Wed 17 Oct     , Daniel Drake (dsd) wrote:
> > >> 1.1                  sys-apps/sandbox/sandbox-1.2.18.1-r1.ebuild
> > >>
> > >> file :
> > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandb
> > >>ox-1.2.18.1-r1.ebuild?rev=1.1&view=markup plain:
> > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandb
> > >>ox-1.2.18.1-r1.ebuild?rev=1.1&content-type=text/plain
> > >>
> > >>      keepdir /var/log/sandbox
> > >>      fowners root:portage /var/log/sandbox
> > >>      fperms 0770 /var/log/sandbox
> > >>
> > >>      cd ${S}
> > >>      dodoc AUTHORS ChangeLog NEWS README
> > >> }
> > >>
> > >> pkg_preinst() {
> > >>      chown root:portage ${D}/var/log/sandbox
> > >>      chmod 0770 ${D}/var/log/sandbox
> > >> }
> > >
> > > How come you need to repeat the permissions like this?
> > >
> > > Also, quoting. =)
> > >
> > > Thanks,
> > > Donnie
> >
> > Also, pkg_preinst() is not binary package safe. So unless the portage
> > group is always the same gid on EVERY Gentoo box. This will break binary
> > packages.
>
> Eh?
>
> pkg_* runs for binpkgs...so depending on the target machine it will
> chown appropriately in $IMAGE and then merge to the livefs.
>
> If you build the binpkg on machine A and install it on B, pkg_preinst
> will run on both (once for the build and one for the install)

Alec is correct, this is perfectly binary safe.  but people should forget he 
ever said "$IMAGE" and pretend he said "$D" ;)
-mike

["signature.asc" (application/pgp-signature)]
-- 
gentoo-dev@gentoo.org mailing list


[prev in list] [next in list] [prev in thread] [next in thread]