[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] position of inherit in ebuilds and checking via repoman
From:       Andrew Ross <aross () westnet ! com ! au>
Date:       2004-03-30 12:13:05
Message-ID: 1080648785.7111.75.camel () localhost
[Download RAW message or body]

While reading ebuild descriptions returned via emerge search, I've
noticed descriptions such as "Based on the eutils eclass".

A quick check of the ebuilds in question show that they are setting
DESCRIPTION before calling inherit.

In bug #36322, SpanKY (vapier@gentoo.org) wrote "you inherit before you
do anything else in ebuilds, read the docs/policy, it should be in there
somewhere". He makes similar statements in bug #15675 

This seems to be supported by the eclass HOWTO
(http://www.gentoo.org/doc/en/eclass-howto.xml), yet there are a still a
number of ebuilds in portage which do not adhere to this convention
(including mainstream packages such as mod_php).

I'm going to submit a bug report (with patch, of course) for each ebuild
I find that uses inherit incorrectly, mainly, because I'm sick of
missing out on the descriptions :-)

Would it be appropriate for repoman to check for the correct use of
inherit?

Cheers

Andrew


--
gentoo-dev@gentoo.org mailing list

[prev in list] [next in list] [prev in thread] [next in thread]