[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] ebuild inconsistencies (was: Community driven meta distribution or only distribution)
From:       Fernand Albarracin <fernand8 () wanadoo ! fr>
Date:       2003-04-29 23:54:37
[Download RAW message or body]

Hi,

On Tue 29 Apr 2003 at 15:31:54 -0400, Grant Goodyear wrote:

> A good "reference" ebuild can be found by "man 5 ebuild".

Just checked it, and have few remarks.

Here is a part of the supplied sample ebuild :

	src_compile() {
	    econf || die "could not configure"
	    emake || die "emake failed"
	}

An here is the revelant documentation :

	...
	*Note:  There  is  no need to use '|| die' because
	econf checks for you

	...
	*Note:  Be  sure  to  use  '||  die' constructs to
	ensure emake success

1. The example should be updated.

	src_compile() {
	    econf
	    emake || die "emake failed"
	}

2. It might be a good idea to change emake so that it works just like
econf and einstall. What do you think ? Goal: get a simpler, more
consistent API.

Also right now econf is implemented as a function, and emake as a
program. Is there a good reason for this ? Sure, it does not really
matter from an ebuild writter point of view, it's more a "spring
cleanup" kind of suggestion.

Ok, enough for today :)

Fernand

--
gentoo-dev@gentoo.org mailing list

[prev in list] [next in list] [prev in thread] [next in thread]