[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-desktop
Subject:    [gentoo-desktop] [PATCH] amarok-1.4.10_p20090130-r4 fail to compile
From:       Alex Efros <powerman () powerman ! name>
Date:       2011-09-27 15:04:03
Message-ID: 20110927150403.GI4290 () home ! power
[Download RAW message or body]

Hi!

Error from build log:

---cut---
In file included from amarokdcophandler.cpp:36:0:
../../../amarok/src/osd.h: At global scope:
../../../amarok/src/osd.h:40:74: error: cannot call constructor 'QImage::QImage' directly
../../../amarok/src/osd.h:40:74: error:   for a function-style cast, remove the redundant '::QImage'
---cut---

Patch (duplicated in attach):

---cut---
--- amarok/src/osd.h.orig       2011-09-27 17:47:26.000000000 +0300
+++ amarok/src/osd.h    2011-09-27 17:47:43.000000000 +0300
@@ -37,7 +37,7 @@
 
       public slots:
         /** calls setText() then show(), after setting image if needed */
-        void show( const QString &text, QImage newImage = QImage::QImage() );
+        void show( const QString &text, QImage newImage = QImage() );
         void ratingChanged( const short rating );
         void ratingChanged( const QString& path, int rating );
         void volChanged( unsigned char volume );
---cut---

I noticed this issue when re-emerging @world after upgrading gcc 4.4.5 to
4.5.3, but probably this issue have nothing with gcc and related to some
previous qt upgrade, so I named patch file amarok-qt3-4.7.patch but I'm
not sure this is correct name.

-- 
			WBR, Alex.

["amarok-qt3-4.7.patch" (application/x-patch)]

--- amarok/src/osd.h.orig	2011-09-27 17:47:26.000000000 +0300
+++ amarok/src/osd.h	2011-09-27 17:47:43.000000000 +0300
@@ -37,7 +37,7 @@
 
       public slots:
         /** calls setText() then show(), after setting image if needed */
-        void show( const QString &text, QImage newImage = QImage::QImage() );
+        void show( const QString &text, QImage newImage = QImage() );
         void ratingChanged( const short rating );
         void ratingChanged( const QString& path, int rating );
         void volChanged( unsigned char volume );

["amarok-1.4.10_p20090130-r4.ebuild.patch" (application/x-patch)]

--- /var/lib/layman/kde-sunset/media-sound/amarok/amarok-1.4.10_p20090130-r=
4.ebuild	2010-11-14 21:17:44.000000000 +0200=0A+++ amarok-1.4.10_p20090130-=
r4.ebuild	2011-09-27 17:49:36.000000000 +0300=0A@@ -77,6 +77,7 @@=0A 	"${FI=
LESDIR}/${PN}-libmp4v2.patch"=0A 	"${FILESDIR}/${PN}-libmp4v2-2.patch"=0A 	=
"${FILESDIR}/${PN}-1.4.10-fix-autoconf-2.64.patch"=0A+	"${FILESDIR}/${PN}-q=
t3-4.7.patch"=0A 	"${WORKDIR}/${PN}-1.4.10-post20090130.diff"=0A 	"${WORKDI=
R}/${PN}-1.4.10-desktop-entry.diff"=0A )=0A

[prev in list] [next in list] [prev in thread] [next in thread]