[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-alt
Subject:    Re: [gentoo-alt] Whois 4.7.26 issues under Solaris 10
From:       Marius Konitzer <m.konitzer () gmx ! de>
Date:       2008-08-06 17:06:37
Message-ID: 1218042398.4472.32.camel () marius ! localnet ! local
[Download RAW message or body]

On Wed, 2008-08-06 at 17:44 +0200, Fabian Groffen wrote: 
> You skip the OPTS="${CFLAGS}" here, has that any reason?  Feels like
> this was necessary to make the build system respect our CFLAGS.
The patch works for me as well when not skipping the OPTS="${CFLAGS}",
but this leads to a needless duplication of some define flags during
compilation. I didn't trace it down too long, probably there is an
equivalent patch that doesn't touch the OPTS="${CFLAGS}", but it looks
quite redundant once we are employing 'append-flags ...', right?

On Wed, 2008-08-06 at 10:32 -0500, Jeremy Olexa wrote:
> On Wed, Aug 6, 2008 at 10:25 AM, <rabbe@bahnhof.se> wrote:
> > * Aborting due to QA concerns: there are files installed outside the
> > prefix
> > * Call stack:
> > * misc-functions.sh:822: <call install_qa_check>
> > * misc-functions.sh:288: die "Aborting due
> > to QA concerns: there are files ins
> > talled outside the prefix"
> 
> The Makefile in the po/ directory doesn't honor $prefix like the
> Makefile does one directory above it. Hence, the source of this
> problem.
Yeah, this is part of what I meant with "2) NLS not working". However
fixing this obvious problem (INSTALLNLSDIR) is not enough as you can see
with my patch. Fixing the main Makefile (LOCALEDIR) is necessary, too,
to inform {whois,mkpasswd}.c about where the locales can be found.

> I think this patch could go upstream to
> gentoo-x86. Even though they won't have this bug there, it may be a
> good idea to fix anyway.
That's right. They simply did not notice this problem because they
always install to /usr/... but they are intrinsically affected anyway.


Marius


[prev in list] [next in list] [prev in thread] [next in thread]