[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    Re: [PATCH users/roland/safe-ctype] Uniformly put `#include "safe-ctype.h"` last among #include dire
From:       Roland McGrath via Gdb-patches <gdb-patches () sourceware ! org>
Date:       2023-04-29 7:36:54
Message-ID: CAB=4xhqLrrvNYZMGqWSjwQ_rb+z_iT0qYaKMoQPh9WWgCqV+ig () mail ! gmail ! com
[Download RAW message or body]

Since his v3 seems to address all your feedback and seems like a clear fix
(WFM), I've committed to trunk on Manoj's behalf.

Thanks,
Roland

On Mon, Apr 24, 2023 at 10:40 AM Roland McGrath <mcgrathr@google.com> wrote:

> That seems easier to maintain without breakage over the long term than my
> version. Can we get that landed forthwith?
>
> Thanks,
> Roland
>
>
> On Mon, Apr 24, 2023 at 10:21 AM Tom Tromey <tom@tromey.com> wrote:
>
>> >>>>> "Roland" == Roland McGrath via Gdb-patches <
>> gdb-patches@sourceware.org> writes:
>>
>> Roland> I didn't touch anything in the libiberty subdirectory since AIUI
>> Roland> that's still copied from the gcc repository.
>>
>> There's also this patch to fix it differently:
>>
>> https://sourceware.org/pipermail/gdb-patches/2023-April/198954.html
>>
>> which isolates the damage to gdb.
>>
>> Tom
>>
>
[prev in list] [next in list] [prev in thread] [next in thread]